# HG changeset patch # User Matti Hamalainen # Date 1601207808 -10800 # Node ID 295c225e31520efd69c0bad9b33c1a87dcbe4caf # Parent d4d2fda123081949615470aed39f9cd9e99db06b urllog: Improve invalid/local IPv4 network check diff -r d4d2fda12308 -r 295c225e3152 urllog.tcl --- a/urllog.tcl Sun Sep 27 14:51:19 2020 +0300 +++ b/urllog.tcl Sun Sep 27 14:56:48 2020 +0300 @@ -261,11 +261,11 @@ ### Handle URLs that have an IPv4-address if {[regexp "(\[a-z\]+)://(\[0-9\]{1,3})\\.(\[0-9\]{1,3})\\.(\[0-9\]{1,3})\\.(\[0-9\]{1,3})" $urlStr urlMatch urlProto ni1 ni2 ni3 ni4]} { # Check if the IP is on local network - if {$ni1 == 127 || $ni1 == 10 || ($ni1 == 192 && $ni2 == 168) || $ni1 == 0} { - urllog_log "URL pointing to local or invalid network, ignored ($urlStr)." + if {$ni1 == 127 || $ni1 == 10 || ($ni1 == 192 && $ni2 == 168)} { + urllog_log "URL pointing to local network, ignored ($urlStr)." return 0 } - if {$ni1 >= 255 || $ni2 >= 255 || $ni3 >= 255 || $ni4 >= 255} { + if {$ni1 == 0 || $ni1 >= 255 || $ni2 >= 255 || $ni3 >= 255 || $ni4 >= 255} { urllog_log "URL pointing to invalid network, ignored ($urlStr)." return 0 }