Mercurial > hg > egg-tcls

changeset 66:140f0492dcd3

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
quotedb: Use TCL function append instead of set foo "$foo..."
author Matti Hamalainen <ccr@tnsp.org>
date Sat, 10 Sep 2011 18:14:13 +0300
parents 31c8c4f50aa6
children eb728cebfe2c
files quotedb.tcl
diffstat 1 files changed, 6 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/quotedb.tcl	Sat Sep 10 17:02:25 2011 +0300
+++ b/quotedb.tcl	Sat Sep 10 18:14:13 2011 +0300
@@ -136,10 +136,10 @@
     set end [string wordend $str $pos]
     set new [expr $end - $pos + 1]
     if {$ulen + $new < $maxlen} {
-      set ustr "$ustr[string range $str $pos $end]"
+      append ustr [string range $str $pos $end]
       set ulen [expr $ulen + $new]
     } else {
-      set ustr "$ustr[string range $str $pos $end]"
+      append ustr [string range $str $pos $end]
       lappend result $ustr
       set ustr ""
       set ulen 0
@@ -204,7 +204,7 @@
   set qoverride [matchattr $uhand n]
   set usql "SELECT utime AS utime FROM $utable WHERE id=$unum"
   if {$qoverride == 0} {
-    set usql "$usql AND user='[qdb_escape $uhand]'"
+    append usql " AND user='[qdb_escape $uhand]'"
     set qextra ""
   } else {
     set qextra " (owner/time override)"
@@ -253,7 +253,7 @@
   set qoverride [matchattr $uhand n]
   set usql "SELECT utime AS utime FROM $utable WHERE id=$unum"
   if {$qoverride == 0} {
-    set usql "$usql AND user='[qdb_escape $uhand]'"
+    append usql " AND user='[qdb_escape $uhand]'"
     set qextra ""
   } else {
     set qextra " (owner/time override)"
@@ -362,10 +362,10 @@
 
   set usql "SELECT total(${utable}_votes.vote) AS uvote, ${utable}.id AS quoteID, ${utable}.utext AS utext, ${utable}.user AS uuser FROM ${utable} LEFT JOIN ${utable}_votes ON ${utable}_votes.urlid = ${utable}.id"
   if {$uindex >= 0} {
-    set usql "$usql WHERE ${utable}.id=$uindex GROUP BY ${utable}.id"
+    append usql " WHERE ${utable}.id=$uindex GROUP BY ${utable}.id"
     qdb_log "$unick searched $utable #$uindex"
   } else {
-    set usql "$usql GROUP BY ${utable}.id ORDER BY RANDOM() LIMIT 1"
+    append usql " GROUP BY ${utable}.id ORDER BY RANDOM() LIMIT 1"
     qdb_log "$unick get random $utable"
   }