changeset 224:aaf433ab696a

urllog: Improve error messages a bit.
author Matti Hamalainen <ccr@tnsp.org>
date Thu, 30 Oct 2014 15:48:43 +0200
parents 606c2a48b2ce
children cb86368b8fcd
files urllog.tcl
diffstat 1 files changed, 6 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/urllog.tcl	Mon Oct 06 19:32:15 2014 +0300
+++ b/urllog.tcl	Thu Oct 30 15:48:43 2014 +0200
@@ -494,19 +494,22 @@
     return 0
   }
 
-  if {[::http::status $utoken] == "timeout"} {
+  set ustatus [::http::status $utoken]
+  if {$ustatus == "timeout"} {
     urllog_verb_msg $urlNick $urlChan "$urlmsg_timeout"
     urllog_log "HTTP request timed out ($urlStr)"
     return 0
   }
 
-  if {[::http::status $utoken] != "ok"} {
+  if {$ustatus != "ok"} {
     urllog_verb_msg $urlNick $urlChan "$urlmsg_errorgettingdoc ([::http::error $utoken])"
     urllog_log "Error in HTTP transaction: [::http::error $utoken] ($urlStr)"
     return 0
   }
 
   # Fixme! Handle redirects!
+  set ustatus [::http::status $utoken]
+  set uscode [::http::code $utoken]
   set ucode [::http::ncode $utoken]
   set udata [::http::data $utoken]
   array set umeta [::http::meta $utoken]
@@ -596,7 +599,7 @@
     return 1
   } else {
     urllog_verb_msg $urlNick $urlChan "$urlmsg_errorgettingdoc ($ucode)"
-    urllog_log "$ucode - $urlStr"
+    urllog_log "Error fetching document: status=$ustatus, code=$ucode, scode=$uscode, url=$urlStr"
   }
 }