# HG changeset patch # User Colin Clark # Date 1525284133 -3600 # Node ID 4b8e42e226dadb5a8f57a396fc8701ad43b686aa # Parent 99245ee344a9f901abbe28d4e8bb7ed9f0821e1b Fix #605: Crash when writing metadata to .svg files https://github.com/BestImageViewer/geeqie/issues/605 This corrects a coding error, which caused the crash. Parhaps the defaults in filefilter.c at about line 238 should be changed to set these files to no-write: pnm, svg, gif, xbm, xpm, bmp, ico, ras But line 228 sets them to writable anyway. diff -r 99245ee344a9 -r 4b8e42e226da src/exiv2.cc --- a/src/exiv2.cc Tue May 01 16:46:59 2018 +0100 +++ b/src/exiv2.cc Wed May 02 19:02:13 2018 +0100 @@ -374,7 +374,7 @@ #endif Exiv2::Image *image = imageData_->image(); - if (!image) Exiv2::Error(21); + if (!image) throw Exiv2::Error(21); image->setExifData(exifData_); image->setIptcData(iptcData_); #if EXIV2_TEST_VERSION(0,16,0)