changeset 1894:45bc99d21e1a

Don't check for existence of DOM objects via if (elem) in order to catch missing references via error log.
author Matti Hamalainen <ccr@tnsp.org>
date Mon, 06 Nov 2017 03:12:42 +0200
parents f9581f28d9f7
children f15d00bb9bd2
files www/search.js
diffstat 1 files changed, 9 insertions(+), 13 deletions(-) [+]
line wrap: on
line diff
--- a/www/search.js	Mon Nov 06 03:12:04 2017 +0200
+++ b/www/search.js	Mon Nov 06 03:12:42 2017 +0200
@@ -76,7 +76,7 @@
   {
     var res = mapList[i];
     var elem = document.getElementById("map_"+ res[0]);
-    if (elem && elem.checked)
+    if (elem.checked)
       searchList.push(res[0]);
   }
 
@@ -275,18 +275,15 @@
     {
       var res = mapList[i];
       var elem = document.getElementById("map_"+ res[0]);
-      if (elem)
+      if (first)
+        same = elem.checked;
+      else
+      if (elem.checked != same)
       {
-        if (first)
-          same = elem.checked;
-        else
-        if (elem.checked != same)
-        {
-          same = false;
-          break;
-        }
-        first = false;
+        same = false;
+        break;
       }
+      first = false;
     }
 
     same = !same;
@@ -295,8 +292,7 @@
     {
       var res = mapList[i];
       var elem = document.getElementById("map_"+ res[0]);
-      if (elem)
-        elem.checked = same;
+      elem.checked = same;
     }
   });
 }