Mercurial > hg > egg-tcls

changeset 572:295c225e3152

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
urllog: Improve invalid/local IPv4 network check
author Matti Hamalainen <ccr@tnsp.org>
date Sun, 27 Sep 2020 14:56:48 +0300
parents d4d2fda12308
children d004944d6afd
files urllog.tcl
diffstat 1 files changed, 3 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/urllog.tcl	Sun Sep 27 14:51:19 2020 +0300
+++ b/urllog.tcl	Sun Sep 27 14:56:48 2020 +0300
@@ -261,11 +261,11 @@
   ### Handle URLs that have an IPv4-address
   if {[regexp "(\[a-z\]+)://(\[0-9\]{1,3})\\.(\[0-9\]{1,3})\\.(\[0-9\]{1,3})\\.(\[0-9\]{1,3})" $urlStr urlMatch urlProto ni1 ni2 ni3 ni4]} {
     # Check if the IP is on local network
-    if {$ni1 == 127 || $ni1 == 10 || ($ni1 == 192 && $ni2 == 168) || $ni1 == 0} {
-      urllog_log "URL pointing to local or invalid network, ignored ($urlStr)."
+    if {$ni1 == 127 || $ni1 == 10 || ($ni1 == 192 && $ni2 == 168)} {
+      urllog_log "URL pointing to local network, ignored ($urlStr)."
       return 0
     }
-    if {$ni1 >= 255 || $ni2 >= 255 || $ni3 >= 255 || $ni4 >= 255} {
+    if {$ni1 == 0 || $ni1 >= 255 || $ni2 >= 255 || $ni3 >= 255 || $ni4 >= 255} {
       urllog_log "URL pointing to invalid network, ignored ($urlStr)."
       return 0
     }